Fix ALU: Use out pin directly instead of internal finalout bus

- Removed invalid finalout internal bus
- Use out[0..7], out[8..15], out[15] directly for flag computation
- Fixes HDL sub-bus restriction error
This commit is contained in:
2025-09-01 15:03:26 -04:00
parent 2b3da7a171
commit b0c57a8a7e
7 changed files with 25 additions and 15 deletions

View File

@@ -41,35 +41,35 @@ CHIP ALU {
ng; // if (out < 0) equals 1, else 0
PARTS:
// Step 1: Handle zx (zero x)
// handle zx (zero x)
Mux16(a=x, b=false, sel=zx, out=x1);
// Step 2: Handle nx (negate x)
// handle nx (negate x)
Not16(in=x1, out=notx1);
Mux16(a=x1, b=notx1, sel=nx, out=x2);
// Step 3: Handle zy (zero y)
// handle zy (zero y)
Mux16(a=y, b=false, sel=zy, out=y1);
// Step 4: Handle ny (negate y)
// handle ny (negate y)
Not16(in=y1, out=noty1);
Mux16(a=y1, b=noty1, sel=ny, out=y2);
// Step 5: Handle f (function: add or and)
// handle f (add or and)
Add16(a=x2, b=y2, out=addout);
And16(a=x2, b=y2, out=andout);
Mux16(a=andout, b=addout, sel=f, out=fout);
// Step 6: Handle no (negate output)
// handle no (negate out)
Not16(in=fout, out=notfout);
Mux16(a=fout, b=notfout, sel=no, out=out, out=finalout);
Mux16(a=fout, b=notfout, sel=no, out=out);
// Step 7: Compute zr (zero flag)
Or8Way(in=finalout[0..7], out=tmp1);
Or8Way(in=finalout[8..15], out=tmp2);
// compute zr (zero flag)
Or8Way(in=out[0..7], out=tmp1);
Or8Way(in=out[8..15], out=tmp2);
Or(a=tmp1, b=tmp2, out=notzr);
Not(in=notzr, out=zr);
// Step 8: Compute ng (negative flag)
And(a=finalout[15], b=true, out=ng);
// compute ng (negative flag)
And(a=out[15], b=true, out=ng);
}