From 84578de625ef85ee2b355181d76e97ccf963699b Mon Sep 17 00:00:00 2001
From: Sean O'Connor <sean@soconnor.dev>
Date: Tue, 10 Dec 2024 14:52:33 -0500
Subject: [PATCH] Refactor personal information handling in LaTeX and update
 GitHub Actions workflow. Changed personal info commands to improve privacy
 and updated workflow to use Ubuntu 24.04, enhancing permissions and artifact
 upload process.

---
 .github/workflows/compile-latex.yml | 24 +++++++++++++++---------
 personal_info.tex                   | 10 +++++-----
 2 files changed, 20 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/compile-latex.yml b/.github/workflows/compile-latex.yml
index 88d6684..0c98579 100644
--- a/.github/workflows/compile-latex.yml
+++ b/.github/workflows/compile-latex.yml
@@ -6,9 +6,13 @@ on:
   pull_request:
     branches: [ main ]
 
+permissions:
+  contents: write
+  packages: read
+
 jobs:
   build-public:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
     - uses: actions/checkout@v3
     
@@ -47,7 +51,7 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
   build-private:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     if: github.actor == github.repository_owner
     steps:
     - uses: actions/checkout@v3
@@ -67,19 +71,21 @@ jobs:
         PERSONAL_HOME_ADDRESS: ${{ secrets.PERSONAL_HOME_ADDRESS }}
         PERSONAL_SCHOOL_ADDRESS: ${{ secrets.PERSONAL_SCHOOL_ADDRESS }}
       run: |
-        cat > personal_info.tex << EOL
+        cat > personal_info.tex << 'EOL'
         % Private version of personal information
         \newcommand{\personalName}{Sean O'Connor}
-        \newcommand{\personalEmail}{${PERSONAL_EMAIL}}
-        \newcommand{\personalPhone}{${PERSONAL_PHONE}}
+        \newcommand{\personalEmail}{$PERSONAL_EMAIL}
+        \newcommand{\personalPhone}{$PERSONAL_PHONE}
         \newcommand{\personalWebsite}{soconnor.dev}
-        \newcommand{\personalSchoolEmail}{${PERSONAL_SCHOOL_EMAIL}}
-        \newcommand{\personalHomeAddress}{${PERSONAL_HOME_ADDRESS}}
-        \newcommand{\personalSchoolAddress}{${PERSONAL_SCHOOL_ADDRESS}}
+        \newcommand{\personalSchoolEmail}{$PERSONAL_SCHOOL_EMAIL}
+        \newcommand{\personalHomeAddress}{$PERSONAL_HOME_ADDRESS}
+        \newcommand{\personalSchoolAddress}{$PERSONAL_SCHOOL_ADDRESS}
         EOL
+        envsubst < personal_info.tex > personal_info.tex.tmp
+        mv personal_info.tex.tmp personal_info.tex
         
     - name: Upload Private PDFs
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: private-documents
         path: |
diff --git a/personal_info.tex b/personal_info.tex
index 9235d5d..a42240f 100644
--- a/personal_info.tex
+++ b/personal_info.tex
@@ -3,9 +3,9 @@
 % For private information, create personal_info_private.tex
 
 \newcommand{\personalName}{Sean O'Connor}
-\newcommand{\personalEmail}{Available upon request}
-\newcommand{\personalPhone}{Available upon request}
+\newcommand{\personalEmail}{Contact for details}
+\newcommand{\personalPhone}{}
 \newcommand{\personalWebsite}{soconnor.dev}
-\newcommand{\personalSchoolEmail}{Available upon request}
-\newcommand{\personalHomeAddress}{Available upon request}
-\newcommand{\personalSchoolAddress}{Available upon request} 
\ No newline at end of file
+\newcommand{\personalSchoolEmail}{}
+\newcommand{\personalHomeAddress}{}
+\newcommand{\personalSchoolAddress}{} 
\ No newline at end of file